Skip to content

ported zNPCSupport and zNPCTypeCommon#587

Merged
JoshSanch merged 2 commits intobfbbdecomp:mainfrom
LivewireCB:main
Jul 14, 2025
Merged

ported zNPCSupport and zNPCTypeCommon#587
JoshSanch merged 2 commits intobfbbdecomp:mainfrom
LivewireCB:main

Conversation

@LivewireCB
Copy link
Contributor

ported zNPCSupport and zNPCTypeCommon from the bfbbpc repo.

All done by @seilweiss

@github-actions
Copy link

⚠️ 🔥

+21436 bytes
🆗 Bot Rating: If I could feel emotions, I would be crying tears of joy right now.

Regressions: 3

⚠️ main/SB/Core/x/xEntMotion - .text -4 bytes -> 0.00%
⚠️ main/SB/Game/zNPCSupport - .sbss -1 bytes -> 27.08%
⚠️ main/SB/Core/x/xEntMotion - xSpline3_ArcTotal(xSpline3*) -4 bytes -> 0.00%

Progress: 84

📈 main/SB/Game/zNPCFXCinematic - .text +12 bytes -> 19.10%
📈 main/SB/Game/zNPCSupport - .text +3104 bytes -> 67.65%
📈 main/SB/Game/zNPCSupport - .bss +64 bytes -> 37.44%
📈 main/SB/Game/zNPCTypeCommon - .rodata +1343 bytes -> 92.67%
📈 main/SB/Game/zNPCTypeCommon - .data +495 bytes -> 33.60%
📈 main/SB/Game/zNPCSupport - .rodata +277 bytes -> 38.91%
📈 main/SB/Game/zNPCSupport - .data +140 bytes -> 27.34%
main/SB/Game/zNPCTypeCommon - .bss +248 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeCommon - .sdata2 +96 bytes -> 81.82%
📈 main/SB/Game/zNPCSupport - .sdata2 +12 bytes -> 39.13%
📈 main/SB/Game/zNPCTypeCommon - .sbss +12 bytes -> 30.77%
main/SB/Game/zNPCSupport - .sdata +5 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeCommon - zNPCCommon::SysEvent(xBase*, xBase*, unsigned int, const float*, xBase*, int*) +2368 bytes -> 99.66%
📈 main/SB/Game/zNPCTypeCommon - zNPCCommon::Setup() +1020 bytes -> 93.41%
main/SB/Game/zNPCTypeCommon - zNPCCommon::ParseINI() +744 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::NPCMessage(NPCMsg*) +724 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeCommon - zNPCCommon::ISeePlayer() +708 bytes -> 98.89%
main/SB/Game/zNPCTypeCommon - zNPCCommon::InitBounds() +688 bytes -> 100.00%
📈 main/SB/Game/zNPCSupport - NPCC_aimVary(xVec3*, xVec3*, xVec3*, float, int, xVec3*) +576 bytes -> 84.71%
📈 main/SB/Game/zNPCTypeCommon - zNPCCommon::HaveLOSToPos(xVec3*, float, xScene*, xBase*, xCollis*) +584 bytes -> 97.99%
📈 main/SB/Game/zNPCTypeCommon - zNPCCommon::CollideReview() +539 bytes -> 99.26%
📈 main/SB/Game/zNPCTypeCommon - zNPCCommon::GetParmDefault(en_npcparm, void*) +372 bytes -> 70.45%
📈 main/SB/Game/zNPCSupport - NPCTarget::FindNearest(int, xBase*, xVec3*, float) +452 bytes -> 87.02%
main/SB/Game/zNPCTypeCommon - zNPCCommon::Damage(en_NPC_DAMAGE_TYPE, xBase*, const xVec3*) +504 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::ConvertHitEvent(xBase*, xBase*, unsigned int, const float*, xBase*, int*) +468 bytes -> 100.00%
📈 main/SB/Game/zNPCSupport - NPCC_GenSmooth(xVec3**, xVec3**) +196 bytes -> 42.98%
main/SB/Game/zNPCTypeCommon - zNPCCommon::GiveReward() +436 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeCommon - zNPCCommon::GetParm(en_npcparm, void*) +228 bytes -> 58.16%
main/SB/Game/zNPCTypeCommon - zNPCCommon::IsAttackFrame(float, int) +388 bytes -> 100.00%
📈 main/SB/Game/zNPCSupport - NPCC_HaveLOSToPos(xVec3*, xVec3*, float, xBase*, xCollis*) +372 bytes -> 96.88%
📈 main/SB/Game/zNPCTypeCommon - zNPCCommon::Reset() +328 bytes -> 90.11%
main/SB/Game/zNPCTypeCommon - zNPCCommon::TagVerts() +364 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeCommon - zNPCCommon::TurnToFace(float, const xVec3*, float) +304 bytes -> 87.36%
📈 main/SB/Game/zNPCTypeCommon - zNPCCommon::MvptCycle() +332 bytes -> 95.40%
main/SB/Game/zNPCTypeCommon - zNPCCommon::BUpdate(xVec3*) +300 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::Init(xEntAsset*) +276 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::AnimStart(unsigned int, int) +276 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::ThrottleApply(float, const xVec3*, int) +268 bytes -> 100.00%
📈 main/SB/Game/zNPCSupport - Firework::FlyFlyFly(float) +188 bytes -> 71.21%
📈 main/SB/Game/zNPCTypeCommon - zNPCCommon::Vibrate(en_npcvibe, float) +12 bytes -> 4.62%
main/SB/Game/zNPCTypeCommon - zNPCCommon::Respawn(const xVec3*, zMovePoint*, zMovePoint*) +252 bytes -> 100.00%
main/SB/Game/zNPCSupport - NPCTarget::InCylinder(xVec3*, float, float, float) +244 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeCommon - zNPCCommon::Move(xScene*, float, xEntFrame*) +210 bytes -> 89.23%
main/SB/Game/zNPCTypeCommon - zNPCCommon::VelStop() +232 bytes -> 100.00%
📈 main/SB/Game/zNPCSupport - NPCC_chk_hitEnt(xEnt*, xBound*, xCollis*) +164 bytes -> 74.55%
main/SB/Game/zNPCTypeCommon - zNPCCommon::ThrottleAdjust(float, float, float) +216 bytes -> 100.00%
📈 main/SB/Game/zNPCSupport - zNPC_SNDInit() +136 bytes -> 64.81%
main/SB/Game/zNPCTypeCommon - zNPCCommon::PlayerKiltMe() +200 bytes -> 100.00%
📈 main/SB/Game/zNPCFXCinematic - NCIN_ArfDogBoom(const zCutsceneMgr*, NCINEntry*, int) +4 bytes -> 2.04%
main/SB/Game/zNPCTypeCommon - zNPCCommon::BoundAsRadius(int) const +184 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCSettings::operator=(const zNPCSettings&) +180 bytes -> 100.00%
main/SB/Game/zNPCSupport - Firework::Update(float) +172 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::ParseLinks() +156 bytes -> 100.00%
📈 main/SB/Game/zNPCSupport - zNPC_SNDPlay3D(_tageNPCSnd, xEnt*) +144 bytes -> 92.31%
main/SB/Game/zNPCSupport - NPCTarget::IsDead() +148 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::NewTime(xScene*, float) +136 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::Vibrate(float, float) +132 bytes -> 100.00%
📈 main/SB/Game/zNPCFXCinematic - NCINBeNosey::CanRenderNow() +3 bytes -> 3.03%
main/SB/Game/zNPCTypeCommon - zNPCCommon::ThrottleAccel(float, int, float) +128 bytes -> 100.00%
main/SB/Game/zNPCSupport - NPCWidget::Off(const zNPCCommon*, int) +128 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::ConfigCreate(unsigned int) +116 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::MvptReset(zMovePoint*) +116 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::ModelAtomicShow(int, xModelInstance*) +100 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::AnimSetState(unsigned int, float) +100 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::AnimCurState() +100 bytes -> 100.00%
📈 main/SB/Game/zNPCFXCinematic - NCIN_ShieldPop(const zCutsceneMgr*, NCINEntry*, int) +4 bytes -> 4.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::ConfigFind(unsigned int) +96 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::AnimCurSingle() +96 bytes -> 100.00%
main/SB/Game/zNPCSupport - zNPC_SNDStop(_tageNPCSnd) +92 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::ModelAtomicHide(int, xModelInstance*) +88 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - xDynAsset::operator=(const xDynAsset&) +84 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::ModelAtomicFind(int, int, xModelInstance*) +80 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCSettings_Find(unsigned int) +76 bytes -> 100.00%
main/SB/Game/zNPCSupport - NPCWidget::Init(en_NPC_UI_WIDGETS) +20 bytes -> 100.00%
main/SB/Game/zNPCSupport - NPCWidget_Startup() +20 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::AnimFindState(unsigned int) +52 bytes -> 100.00%
main/SB/Game/zNPCSupport - NPCC_chk_hitPlyr(xBound*, xCollis*) +52 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::GetParm(en_npcparm, int*) +44 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::GetParm(en_npcparm, float*) +44 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::GetParm(en_npcparm, xVec3*) +44 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::GetParm(en_npcparm, zMovePoint**) +44 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zNPCCommon::ModelScaleSet(float, float, float) +36 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - xBaseAsset::operator=(const xBaseAsset&) +36 bytes -> 100.00%
main/SB/Game/zNPCTypeCommon - zMovePoint::HasSpline() +20 bytes -> 100.00%

@JoshSanch JoshSanch merged commit c3eaf8d into bfbbdecomp:main Jul 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants